Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > To yield better TX performance, wake TX queue is implemented. I went looking for this, and was happy to find it! :) Do you also support airtime reporting and/or AQL? And if not, any plans to do so? One small nit below: > +static void rtw89_ops_wake_tx_queue(struct ieee80211_hw *hw, > + struct ieee80211_txq *txq) > +{ > + struct rtw89_dev *rtwdev = hw->priv; > + > + ieee80211_schedule_txq(hw, txq); > + queue_work(rtwdev->txq_wq, &rtwdev->txq_work); Why the call to ieee80211_schedule_txq()? mac80211 calls that before calling wake_tx_queue() (through the schedule_and_wake_txq() helper), so it seems a bit superfluous here? -Toke