> -----Original Message----- > From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx <kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx> On > Behalf Of Kalle Valo > Sent: Saturday, October 2, 2021 12:34 AM > To: Pkshih <pkshih@xxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver > > Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > > > This driver named rtw89, which is the next generation of rtw88, supports > > Realtek 8852AE 802.11ax 2x2 chip whose new features are OFDMA, DBCC, > > Spatial reuse, TWT and BSS coloring; now some of them aren't implemented > > though. > > > > The chip architecture is entirely different from the chips supported by > > rtw88 like RTL8822CE 802.11ac chip. First of all, register address ranges > > are totally redefined, so it's impossible to reuse register definition. To > > communicate with firmware, new H2C/C2H format is proposed. In order to have > > better utilization, TX DMA flow is changed to two stages DMA. To provide > > rich RX status information, additional RX PPDU packets are added. > > > > Since there are so many differences mentioned above, we decide to propose > > a new driver. It has many authors, they are listed in alphabetic order: > > I did a review now and this looks pretty good to me. Kconfig has a > different license and lots of static/extern variables which are not > const, otherwise I only saw smaller issues. But I do have to admit that > after mac.h (in alphabetical order) my review was more on the sloppy > side, this is a large driver. Thank you. I will revise the driver according to your comments. > > The community has been testing this driver already, right? As Larry mentioned, end users use this driver. Since bugs found in v6, we have fixed them and driver is under QA. I plan to have that fixes in v7 released this week. This version will also include fixes of your comments. Does it work to you? > > I pushed the driver to the pending branch for build testing: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?h= > pending&id=c9dfa866a9f4004fcbde9fc3ad8772ad417c6ad9 > -- Ping-Ke
