Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > On 10/1/21 11:34, Kalle Valo wrote: >> Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: >> >>> This driver named rtw89, which is the next generation of rtw88, supports >>> Realtek 8852AE 802.11ax 2x2 chip whose new features are OFDMA, DBCC, >>> Spatial reuse, TWT and BSS coloring; now some of them aren't implemented >>> though. >>> >>> The chip architecture is entirely different from the chips supported by >>> rtw88 like RTL8822CE 802.11ac chip. First of all, register address ranges >>> are totally redefined, so it's impossible to reuse register definition. To >>> communicate with firmware, new H2C/C2H format is proposed. In order to have >>> better utilization, TX DMA flow is changed to two stages DMA. To provide >>> rich RX status information, additional RX PPDU packets are added. >>> >>> Since there are so many differences mentioned above, we decide to propose >>> a new driver. It has many authors, they are listed in alphabetic order: >> >> I did a review now and this looks pretty good to me. Kconfig has a >> different license and lots of static/extern variables which are not >> const, otherwise I only saw smaller issues. But I do have to admit that >> after mac.h (in alphabetical order) my review was more on the sloppy >> side, this is a large driver. >> >> The community has been testing this driver already, right? > > Kalle, > > As soon as Ping-Ke submitted this driver, I created a stand-alone > version at GitHub so that people with new laptops containing this chip > would have a source for the driver. There have been minor hiccups that > we have fixed along the way. I am also testing it on my system. Nice, so I can assume there are quite a few users for this driver already? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
