Loic Poulain <loic.poulain@xxxxxxxxxx> writes:
> Hi Kalle,
>
> On Thu, 16 Sept 2021 at 10:00, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>>
>> Hi Loic and Mani,
>>
>> I hate to be the bearer of bad news again :)
>>
>> I noticed already a while ago that commit 020d3b26c07a ("bus: mhi: Early
>> MHI resume failure in non M3 state"), introduced in v5.13-rc1, broke
>> ath11k resume on my NUC x86 testbox using QCA6390. Interestingly enough
>> Dell XPS 13 9310 laptop (with QCA6390 as well) does not have this
>> problem, I only see the problem on the NUC. I do not know what's causing
>> this difference.
>
> I suppose the NUC is current PCI-Express power during suspend while
> the laptop maintains PCIe/M2 power.
Sorry, I'm not able to parse that sentence. Can you elaborate more?
>> At the moment I'm running my tests with commit 020d3b26c07a reverted and
>> everything works without problems. Is there a simple way to fix this? Or
>> maybe we should just revert the commit? Commit log and kernel logs from
>> a failing case below.
>
> Do you have log of success case?
A log from a successful case in the end of email, using v5.15-rc1 plus
revert of commit 020d3b26c07abe27.
> To me, the device loses power, that is why MHI resuming is failing.
> Normally the device should be properly recovered/reinitialized. Before
> that patch the power loss was simply not detected (or handled at
> higher stack level).
Currently in ath11k we always keep the firmware running when in suspend,
this is a workaround due to problems between mac80211 and MHI stack.
IIRC the problem was something related MHI creating struct device during
resume or something like that.
[ 164.088772] PM: suspend entry (deep)
[ 164.089867] Filesystems sync: 0.000 seconds
[ 164.140383] Freezing user space processes ... (elapsed 0.004 seconds) done.
[ 164.146245] OOM killer disabled.
[ 164.148024] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[ 164.151767] printk: Suspending console(s) (use no_console_suspend to debug)
[ 164.155767] wlan0: deauthenticating from <SENSORED> by local choice (Reason: 3=DEAUTH_LEAVING)
[ 164.197460] e1000e: EEE TX LPI TIMER: 00000011
[ 164.787849] ACPI: EC: interrupt blocked
[ 164.863887] ACPI: PM: Preparing to enter system sleep state S3
[ 164.898479] ACPI: EC: event blocked
[ 164.898483] ACPI: EC: EC stopped
[ 164.898487] ACPI: PM: Saving platform NVS memory
[ 164.898496] Disabling non-boot CPUs ...
[ 164.910527] numa_remove_cpu cpu 1 node 0: mask now 0,2-7
[ 164.911609] smpboot: CPU 1 is now offline
[ 164.929506] numa_remove_cpu cpu 2 node 0: mask now 0,3-7
[ 164.930593] smpboot: CPU 2 is now offline
[ 164.947111] numa_remove_cpu cpu 3 node 0: mask now 0,4-7
[ 164.948192] smpboot: CPU 3 is now offline
[ 164.965687] numa_remove_cpu cpu 4 node 0: mask now 0,5-7
[ 164.967133] smpboot: CPU 4 is now offline
[ 164.983150] numa_remove_cpu cpu 5 node 0: mask now 0,6-7
[ 164.984211] smpboot: CPU 5 is now offline
[ 164.992047] numa_remove_cpu cpu 6 node 0: mask now 0,7
[ 164.993549] smpboot: CPU 6 is now offline
[ 165.004382] numa_remove_cpu cpu 7 node 0: mask now 0
[ 165.005456] smpboot: CPU 7 is now offline
[ 165.009866] ACPI: PM: Low-level resume complete
[ 165.010106] ACPI: EC: EC started
[ 165.010109] ACPI: PM: Restoring platform NVS memory
[ 165.012344] Enabling non-boot CPUs ...
[ 165.012978] x86: Booting SMP configuration:
[ 165.012984] smpboot: Booting Node 0 Processor 1 APIC 0x2
[ 165.014850] numa_add_cpu cpu 1 node 0: mask now 0-1
[ 165.023818] CPU1 is up
[ 165.024455] smpboot: Booting Node 0 Processor 2 APIC 0x4
[ 165.026190] numa_add_cpu cpu 2 node 0: mask now 0-2
[ 165.034904] CPU2 is up
[ 165.035479] smpboot: Booting Node 0 Processor 3 APIC 0x6
[ 165.037193] numa_add_cpu cpu 3 node 0: mask now 0-3
[ 165.046102] CPU3 is up
[ 165.046639] smpboot: Booting Node 0 Processor 4 APIC 0x1
[ 165.047005] numa_add_cpu cpu 4 node 0: mask now 0-4
[ 165.058328] CPU4 is up
[ 165.058976] smpboot: Booting Node 0 Processor 5 APIC 0x3
[ 165.059342] numa_add_cpu cpu 5 node 0: mask now 0-5
[ 165.070520] CPU5 is up
[ 165.071192] smpboot: Booting Node 0 Processor 6 APIC 0x5
[ 165.071574] numa_add_cpu cpu 6 node 0: mask now 0-6
[ 165.082952] CPU6 is up
[ 165.083609] smpboot: Booting Node 0 Processor 7 APIC 0x7
[ 165.083980] numa_add_cpu cpu 7 node 0: mask now 0-7
[ 165.095544] CPU7 is up
[ 165.099137] ACPI: PM: Waking up from system sleep state S3
[ 166.045084] ACPI: EC: interrupt unblocked
[ 166.045242] pcieport 0000:00:1c.4: Intel SPT PCH root port ACS workaround enabled
[ 166.056234] pcieport 0000:00:1c.1: Intel SPT PCH root port ACS workaround enabled
[ 166.057410] pcieport 0000:00:1d.0: Intel SPT PCH root port ACS workaround enabled
[ 166.057413] pcieport 0000:00:1c.2: Intel SPT PCH root port ACS workaround enabled
[ 167.210794] ACPI: EC: event unblocked
[ 167.258815] nvme nvme0: 8/0/0 default/read/poll queues
[ 167.694965] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[ 167.695953] OOM killer enabled.
[ 167.697336] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[ 167.750241] Restarting tasks ... done.
[ 167.770450] PM: suspend exit
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
