Search Linux Wireless

Re: [PATCH] cfg80211: AP mode driver offload for FILS association crypto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Subrat,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on next-20210908]
[cannot apply to mac80211/master v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Subrat-Mishra/cfg80211-AP-mode-driver-offload-for-FILS-association-crypto/20210908-145513
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: x86_64-randconfig-a006-20210908 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/5f1db10bda1cc92823809fe6d36a487c9bca883b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Subrat-Mishra/cfg80211-AP-mode-driver-offload-for-FILS-association-crypto/20210908-145513
        git checkout 5f1db10bda1cc92823809fe6d36a487c9bca883b
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from net/wireless/sysfs.c:16:
>> include/net/cfg80211.h:765:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
     765 | static inline enum nl80211_channel_type
         | ^~~~~~
>> include/net/cfg80211.h:765:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
   include/net/cfg80211.h:765:15: error: expected ';', identifier or '(' before 'enum'
     765 | static inline enum nl80211_channel_type
         |               ^~~~
   include/net/cfg80211.h:765:15: error: 'inline' in empty declaration
>> include/net/cfg80211.h:766:1: warning: no previous prototype for 'cfg80211_get_chandef_type' [-Wmissing-prototypes]
     766 | cfg80211_get_chandef_type(const struct cfg80211_chan_def *chandef)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from net/wireless/trace.h:12,
                    from net/wireless/trace.c:5:
>> include/net/cfg80211.h:765:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
     765 | static inline enum nl80211_channel_type
         | ^~~~~~
>> include/net/cfg80211.h:765:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
   include/net/cfg80211.h:765:15: error: expected ';', identifier or '(' before 'enum'
     765 | static inline enum nl80211_channel_type
         |               ^~~~
   include/net/cfg80211.h:765:15: error: 'inline' in empty declaration
>> include/net/cfg80211.h:766:1: warning: no previous prototype for 'cfg80211_get_chandef_type' [-Wmissing-prototypes]
     766 | cfg80211_get_chandef_type(const struct cfg80211_chan_def *chandef)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/trace.h:3683,
                    from net/wireless/trace.c:5:
   include/trace/define_trace.h:95:42: fatal error: ./trace.h: No such file or directory
      95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
         |                                          ^
   compilation terminated.


vim +/static +765 include/net/cfg80211.h

5f1db10bda1cc92 Subrat Mishra  2021-09-08  757  
3d9d1d6656a73ea Johannes Berg  2012-11-08  758  /**
3d9d1d6656a73ea Johannes Berg  2012-11-08  759   * cfg80211_get_chandef_type - return old channel type from chandef
3d9d1d6656a73ea Johannes Berg  2012-11-08  760   * @chandef: the channel definition
3d9d1d6656a73ea Johannes Berg  2012-11-08  761   *
0ae997dc75efb60 Yacine Belkadi 2013-01-12  762   * Return: The old channel type (NOHT, HT20, HT40+/-) from a given
3d9d1d6656a73ea Johannes Berg  2012-11-08  763   * chandef, which must have a bandwidth allowing this conversion.
3d9d1d6656a73ea Johannes Berg  2012-11-08  764   */
683b6d3b31a5195 Johannes Berg  2012-11-08 @765  static inline enum nl80211_channel_type
683b6d3b31a5195 Johannes Berg  2012-11-08 @766  cfg80211_get_chandef_type(const struct cfg80211_chan_def *chandef)
683b6d3b31a5195 Johannes Berg  2012-11-08  767  {
3d9d1d6656a73ea Johannes Berg  2012-11-08  768  	switch (chandef->width) {
3d9d1d6656a73ea Johannes Berg  2012-11-08  769  	case NL80211_CHAN_WIDTH_20_NOHT:
3d9d1d6656a73ea Johannes Berg  2012-11-08  770  		return NL80211_CHAN_NO_HT;
3d9d1d6656a73ea Johannes Berg  2012-11-08  771  	case NL80211_CHAN_WIDTH_20:
3d9d1d6656a73ea Johannes Berg  2012-11-08  772  		return NL80211_CHAN_HT20;
3d9d1d6656a73ea Johannes Berg  2012-11-08  773  	case NL80211_CHAN_WIDTH_40:
3d9d1d6656a73ea Johannes Berg  2012-11-08  774  		if (chandef->center_freq1 > chandef->chan->center_freq)
3d9d1d6656a73ea Johannes Berg  2012-11-08  775  			return NL80211_CHAN_HT40PLUS;
3d9d1d6656a73ea Johannes Berg  2012-11-08  776  		return NL80211_CHAN_HT40MINUS;
3d9d1d6656a73ea Johannes Berg  2012-11-08  777  	default:
3d9d1d6656a73ea Johannes Berg  2012-11-08  778  		WARN_ON(1);
3d9d1d6656a73ea Johannes Berg  2012-11-08  779  		return NL80211_CHAN_NO_HT;
3d9d1d6656a73ea Johannes Berg  2012-11-08  780  	}
3d9d1d6656a73ea Johannes Berg  2012-11-08  781  }
3d9d1d6656a73ea Johannes Berg  2012-11-08  782  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux