On Tue, 2021-09-07 at 19:30 +0800, Kai-Heng Feng wrote: > Hi Luca, > > On Wed, Feb 10, 2021 at 8:00 PM Luca Coelho <luca@xxxxxxxxx> wrote: > > > > From: Luca Coelho <luciano.coelho@xxxxxxxxx> > > > > When reading the PPAG table from ACPI, we should store everything in > > our fwrt structure, so it can be accessed later. But we had a local > > ppag_table variable in the function and were erroneously storing the > > enabled/disabled flag in it instead of storing it in the fwrt. Fix > > this by removing the local variable and storing everything directly in > > fwrt. > > This patch enables PPAG, but it breaks one of HP laptop with Intel 9560. > > dmesg with iwlwifi.debug=0x80 attached in the bug report: > https://bugzilla.kernel.org/show_bug.cgi?id=214343 Thanks for the report. There seems to be an incompatibility between the command the driver is sending to the FW and the version the FW supports. The commit you mentioned just enables sending this commands, which was mistakenly not sent before. Let's continue this discussion in bugzilla. I'll add more information there as I figure it out. -- Cheers, Luca.
