From: dingsenjie <dingsenjie@xxxxxxxxxx> The label just used as return, so we delete it and use the return statement instead of the goto statement. Signed-off-by: dingsenjie <dingsenjie@xxxxxxxxxx> --- drivers/net/wireless/ath/ath5k/base.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 4c6e57f..9739189 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -1896,23 +1896,18 @@ static int ath5k_remove_padding(struct sk_buff *skb) struct ath5k_vif *avf; struct sk_buff *skb; - if (WARN_ON(!vif)) { - ret = -EINVAL; - goto out; - } + if (WARN_ON(!vif)) + return -EINVAL; skb = ieee80211_beacon_get(hw, vif); - if (!skb) { - ret = -ENOMEM; - goto out; - } + if (!skb) + return -ENOMEM; avf = (void *)vif->drv_priv; ath5k_txbuf_free_skb(ah, avf->bbuf); avf->bbuf->skb = skb; ret = ath5k_beacon_setup(ah, avf->bbuf); -out: return ret; } -- 1.9.1