Hello Johannes, I agree that it is odd to combine this new attribute with the existing parameters. I will be removing "he_ul_mcs" out of cfg80211_bitrate_mask and passing it as a separate attribute in next version. Thank you, Muna -----Original Message----- From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Sent: Tuesday, August 17, 2021 6:49 AM To: Muna Sinada <msinada@xxxxxxxxxxxxxx> Cc: linux-wireless@xxxxxxxxxxxxxxx Subject: Re: [PATCH v2] nl80211: Add HE UL MU fixed rate setting Hi, On Thu, 2021-07-29 at 12:41 -0700, Muna Sinada wrote: > This patch adds nl80211 definitions, policies and parsing code > required to pass HE UL MU fixed rate settings. > I don't understand how this is sufficient? > enum nl80211_txrate_gi gi; > enum nl80211_he_gi he_gi; > enum nl80211_he_ltf he_ltf; Previously, for HE rates, we had configurations for: * HE MCS * HE guard interval * HE LTF I guess I can sort of follow that uplink traffic is a bit different and not already configured by the setting for rate control we have today, but why does it not need all these parameters? Also, why is this not a per-station parameter? OK, maybe we don't really want it to be a per-station parameter, or maybe the firmware/algorithm that's selecting things there can't deal with that, but it feels odd to combine it with the "rate control fixed rate" parameters you have here, and do that without even any explanation of how this is supposed to work. This is going to need some work. johannes
