On 2021-08-26 18:59, Johannes Berg wrote:
On Thu, 2021-08-26 at 18:57 +0800, Wen Gong wrote:
On 2021-08-26 16:20, Johannes Berg wrote:
> > struct cfg80211_chan_def {
> > struct ieee80211_channel *chan;
> > @@ -684,6 +685,7 @@ struct cfg80211_chan_def {
> > u32 center_freq2;
> > struct ieee80211_edmg edmg;
> > u16 freq1_offset;
> > + enum nl80211_ap_reg_power power_type;
>
> I'm not sure why this should be in the chandef, there's no way that
> anything in cfg80211 is ever using it there, at least in your patches.
>
It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse
regulatory
info in 6 GHz operation information.
should i move it to mac80211's .h file?
> > +/**
> > + * enum nl80211_ap_reg_power - regulatory power for a Access Point
[...]
>
It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse
regulatory
info in 6 GHz operation information.
should i move it to mac80211's .h file?
Yeah I saw both of them are used, but why are they defined as nl80211
API? Do you have any intention to set them through nl80211?
And like I said, I'm not really convinced this belongs into struct
cfg80211_chan_def either. Maybe it should be in bss_conf too?
yes, I also want to move it to struct ieee80211_bss_conf.
johannes
