Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: > On Aug 19, Kalle Valo wrote: >> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: >> >> > Report tx rate from tx status packets instead of receiving periodic mcu >> > event. This improves flexibility, accuracy and AQL performance, and >> > simplifies code flow for better readability. >> > >> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> >> >> [...] >> >> > + /* We don't support reading GI info from txs packets. >> > + * For accurate tx status reporting and AQL improvement, >> > + * we need to make sure that flags match so polling GI >> > + * from per-sta counters directly. >> > + */ >> > + rate = &msta->wcid.rate; >> > + addr = MT_WTBL_LMAC_OFFS(idx, 0) + 7 * 4; >> >> Magic values. > > ack, I reused what was already in mt7921_mac_sta_poll(), but I can add some > definitions :) Heh, I guess then I have been doing sloppy review earlier :) But thanks for fixing these, we should not repeat past mistakes. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
