Ryder Lee <ryder.lee@xxxxxxxxxxxx> writes: > On Thu, 2021-08-19 at 18:32 +0300, Kalle Valo wrote: >> Ryder Lee <ryder.lee@xxxxxxxxxxxx> writes: >> >> > Fix reasonable checkpatch warnings. >> > >> > Signed-off-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> >> >> One logical change per patch, please. > > I prefer collection all checkpatch warnings into the single patch. But in upstream we prefer one logical change per patch, for example makes it a lot easier to review and bisect. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches