On Sunday 28 September 2008, Gertjan van Wingerde wrote: > Ivo van Doorn wrote: > > On Sunday 28 September 2008, Gertjan van Wingerde wrote: > > > >> Ivo, > >> > >> Ivo van Doorn wrote: > >> > >>>> Ivo, please explain what rt2x00 module(s) you want to be built. In > >>>> English > >>>> if possible, not in Kconfig language... > >>>> > >>>> > >>> There are 3 kind of rt2x00 modules: > >>> rt2x00lib > >>> rt2x00pci/usb > >>> rt2x00 driver (rt2400pci, rt2500pci, rt61pci, rt2500usb, rt73usb) > >>> > >>> When the user selects any of the rt2x00 drivers, the rt2x00pci/usb and rt2x00lib > >>> are selected. For rt2x00lib there are some additional configuration options like > >>> RT2X00_LIB_RFKILL and RT2X00_LIB_LEDS which will build into rt2x00lib. > >>> > >>> This means that when rt2400pci is selected as module, rt2x00pci and rt2x00lib > >>> must be built as modules as well and when rt2400pci is selected as buildin > >>> rt2x00pci and rt2x00lib must be buildin as well. > >>> > >>> But with the optional rt2x00lib configuration options the breakage you reported > >>> is possible. So we either need: > >>> 1) Force rt2x00lib / driver to be compiled as module when RFKILL/LEDS were > >>> compiled as module > >>> 2) Disable config option when invalid config combination is found > >>> > >>> Personally I would favor 1), because 2) could lead to confusion to users > >>> who think they selected everything they needed to enable support for it in > >>> rt2x00. > >>> > >>> > >> Find attached a patch that implements option 2, along with adding a > >> warning to the user when rfkill support in rt2x00 is disabled due to the > >> invalid config combination. I've looked at implementing option 1, but > >> couldn't find a way to do it without disabling the entire rt2x00 module > >> when rfkill wasn't available. > >> > >> I guess we can live with this option for now, until we have figured out > >> how to do option 1. > >> > > > > Sounds good, but please change RT2X00 in RT2X00_LIB > > > > default y if (RT2X00=y&& RFKILL=y) || (RT2X00=m&& RFKILL!=n) > > > > Could you also do a similar thing for the LED handling? > > That way we can fix the entire thing with a single patch. :) > > Here is an updated patch. This required some more surgery to the Kconfig > file, as symbols had to be moved in the file. > This patch fixes the build issues for both rfkill and leds support. Thanks, you can add my: Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx> John, can you merge the patch into wireless-testing? Thanks, Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
