On 2021/8/17 21:39, Jakub Kicinski wrote: > On Tue, 17 Aug 2021 10:36:05 +0800 Yufeng Mo wrote: >> In order to support more coalesce parameters through netlink, >> add an new structure kernel_ethtool_coalesce, and keep >> struct ethtool_coalesce as the base(legacy) part, then the >> new parameter can be added into struct kernel_ethtool_coalesce. >> >> Also add new extack parameter for .set_coalesce and .get_coalesce >> then some extra info can return to user with the netlink API. >> >> Signed-off-by: Yufeng Mo <moyufeng@xxxxxxxxxx> >> Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx> > > This and the following patches don't build, please make sure > allmodconfig builds correctly. Here's an example failure, but > IDK if there isn't more: > > drivers/net/ethernet/ti/davinci_emac.c: In function ‘emac_dev_open’: > drivers/net/ethernet/ti/davinci_emac.c:1469:3: error: too few arguments to function ‘emac_set_coalesce’ > 1469 | emac_set_coalesce(ndev, &coal); > | ^~~~~~~~~~~~~~~~~ > . > Sorry, I'll check allmodconfig again and make sure all builds correctly.
