On 2021-08-04 15:44, greearb@xxxxxxxxxxxxxxx wrote: > From: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > This will let us update stats and wcid.rate for every TXS > callback we receive for a particular wcid. > > For now, the TXS is not requested for NO_SKB frames, however. > That will be allowed in next patch. > > Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > --- > .../net/wireless/mediatek/mt76/mt7915/mac.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > index 6f92e207680f..2228dad71657 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > @@ -1047,6 +1047,7 @@ void mt7915_mac_write_txwi(struct mt7915_dev *dev, __le32 *txwi, > txwi[4] = 0; > > val = FIELD_PREP(MT_TXD5_PID, pid); > + /* NOTE: mt7916 does NOT request TXS for 'NO_SKB' frames by default. */ I think this comment can be dropped, given that you're adding extra checks in the next patch that clarify this. > if (pid >= MT_PACKET_ID_FIRST) > val |= MT_TXD5_TX_STATUS_HOST; > txwi[5] = cpu_to_le32(val); - Felix
