Hello Johannes,
I saw on your review comment that this wrapper is not needed. I wanted to confirm with you if it would be ok to call a cfg80211 API from a mac80211 based driver, since that is what would be done if this wrapper is removed. Additionally, another reason I have this wrapper is so I can place a tracepoint. What are your thoughts about this?
Thank you,
Muna
-----Original Message-----
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Sent: Friday, February 12, 2021 12:49 AM
To: Muna Sinada <msinada@xxxxxxxxxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/2] mac80211: Handling driver updated MU-EDCA params
> +void ieee80211_update_muedca_params(struct ieee80211_hw *hw,
> + struct ieee80211_mu_edca_param_set
> + *params, gfp_t gfp)
> +{
> + struct ieee80211_local *local = hw_to_local(hw);
> +
> + trace_api_update_muedca_params(local, params);
> +
> + cfg80211_update_muedca_params_event(local->hw.wiphy, params, gfp); }
> +EXPORT_SYMBOL(ieee80211_update_muedca_params);
>
I see no reason to have this trivial wrapper.
johannes
