Search Linux Wireless

Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pkshih <pkshih@xxxxxxxxxxx>, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Subject: Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Mon, 09 Aug 2021 22:00:34 +0200
Cc: "linux-wireless@xxxxxxxxxxxxxxx" <linux-wireless@xxxxxxxxxxxxxxx>, "tony0620emma@xxxxxxxxx" <tony0620emma@xxxxxxxxx>, "kvalo@xxxxxxxxxxxxxx" <kvalo@xxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Neo Jou <neojou@xxxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
In-reply-to: <981001e2981346ada4dcc08558b87a18@realtek.com>
References: <20210717204057.67495-1-martin.blumenstingl@googlemail.com> <20210717204057.67495-4-martin.blumenstingl@googlemail.com> <27d8246ef3c9755b3e6e908188ca36f7b0fab3fc.camel@sipsolutions.net> <CAFBinCAzoPmtvH1Wn9dY4pFsERQ5N+0xXRG=UB1eEGe_qTf+6w@mail.gmail.com> <981001e2981346ada4dcc08558b87a18@realtek.com>
User-agent: Evolution 3.38.4 (3.38.4-1.fc33)

> 
> I am thinking rtw88 needs to maintain sta and vif lists itself, 

I would tend to prefer drivers do not maintain separate lists - that's
just duplicated book-keeping and prone to state mismatch errors?

But OTOH the locking does make things complex.

johannes

References:
- [PATCH RFC v1 0/7] rtw88: prepare locking for SDIO support
  - From: Martin Blumenstingl
- [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers
  - From: Martin Blumenstingl
- Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers
  - From: Johannes Berg
- Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers
  - From: Martin Blumenstingl
- RE: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers
  - From: Pkshih

Prev by Date: Re: [PATCH v2] ath10k: fix wmi mgmt tx queue full due to race condition
Next by Date: Re: [PATCH v2] wireless-regdb: recent FCC report and order allows 5850-5895 immediately
Previous by thread: RE: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers
Next by thread: RE: [PATCH RFC v1 0/7] rtw88: prepare locking for SDIO support
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]