Linus Walleij <linus.walleij@xxxxxxxxxx> writes: > On Tue, Aug 3, 2021 at 5:09 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote: > >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> >> >> Currently the variable ret is uninitialized and is only set if >> the pointer alt_path is non-null. Fix this by ininitializing ret >> to zero. >> >> Addresses-Coverity: ("Uninitialized scalar variable") >> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries") >> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Nice catch! > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> I assume this will be fixed by Linus' patch "brcmfmac: firmware: Fix firmware loading" and I should drop Colin's patch, correct? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches