On Tue, Jul 27, 2021 at 11:16:11AM -0700, Brian Norris wrote: > On Mon, Jul 26, 2021 at 11:34 PM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > > > Len Baker <len.baker@xxxxxxx> writes: > > > > > The rtw_pci_init_rx_ring function is only ever called with a fixed > > > constant or RTK_MAX_RX_DESC_NUM for the "len" argument. Since this > > > constant is defined as 512, the "if (len > TRX_BD_IDX_MASK)" check > > > can never happen (TRX_BD_IDX_MASK is defined as GENMASK(11, 0) or in > > > other words as 4095). > > > > > > So, remove this check. > > > > > > Signed-off-by: Len Baker <len.baker@xxxxxxx> > > > > Are everyone ok with this version? > > I suppose? I'm not really sure where the line should be drawn on > excessive bounds checking, false warnings from otherwise quite useful > static analysis tools, etc., but I suppose it doesn't make much sense > to add additional excess bounds checks just to quiet Coverity. > > It might be nice to include the true motivation in the patch > description though, which is: "this also quiets a false warning from > Coverity". Ok, I will send a new version with the commit changelog updated. > > Anyway, feel free to pick one of these: > > Shrug-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > or > > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> Thanks, Len
