Hi, Sorry it took me so long to look at this. I started earlier, but then found some questions and then ... sorry. > > +/** > + * enum nl80211_ap_reg_power - regulatory power for a Access Point > + * > + * @NL80211_REG_UNSET_AP: Access Point has no regulatory power mode > + * @NL80211_REG_LPI: Indoor Access Point > + * @NL80211_REG_SP: Standard power Access Point > + * @NL80211_REG_VLP: Very low power Access Point > + */ > +enum nl80211_ap_reg_power { > + NL80211_REG_UNSET_AP, > + NL80211_REG_LPI_AP, > + NL80211_REG_SP_AP, > + NL80211_REG_VLP_AP, > + NL80211_REG_MAX_AP_TYPE = 3, That last one is missing docs. Also, why should it be numbered explicitly? Better add something like NUM_NL80211_REG_POWER_TYPE, NL80211_REG_MAX_TYPE = NUM_NL80211_REG_POWER_TYPE - 1 or something? > +enum nl80211_client_reg_power { > + NL80211_REG_UNSET_CLIENT, > + NL80211_REG_DEFAULT_CLIENT, > + NL80211_REG_SUBORDINATE_CLIENT, > + NL80211_REG_MAX_CLIENT_TYPE = 2, same here. johannes