RE: [PATCH 14/24] rtw89: 8852a: add 8852a RFK files

[Pkshih <pkshih@xxxxxxxxxxx>]

> -----Original Message-----
> From: Oleksij Rempel [mailto:o.rempel@xxxxxxxxxxxxxx]
> Sent: Saturday, July 10, 2021 1:41 AM
> To: Pkshih
> Cc: kvalo@xxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 14/24] rtw89: 8852a: add 8852a RFK files
> 
> On Fri, Jun 18, 2021 at 02:46:15PM +0800, Ping-Ke Shih wrote:
> > RFK contains DACK, IQK, LOK, RCK, RX DCK, DPK and TSSI. They are called by
> > rfk_init, rfk_channel and rfk_track at the occasions of initialization,
> > channel switch and periodic track respectively.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> > ---
> >  .../net/wireless/realtek/rtw89/rtw8852a_rfk.c | 3806 +++++++++++++++++
> >  .../net/wireless/realtek/rtw89/rtw8852a_rfk.h |   22 +
> >  2 files changed, 3828 insertions(+)
> >  create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> >  create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.h
> >
> > diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> > new file mode 100644
> > index 000000000000..23932784e6e1
> > --- /dev/null
> > +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> > @@ -0,0 +1,3806 @@

[...]

> > +void rtw8852a_tssi_scan(struct rtw89_dev *rtwdev, enum rtw89_phy_idx phy)
> > +{
> > +	u8 i;
> > +
> > +	return;
> 
> rtw8852a_tssi_scan() is not executed. Please remove with all
> dependencies.
> 

This 'return', which is typo, will be removed, so rtw8852a_tssi_scan() will be kept.

> > +	rtw89_debug(rtwdev, RTW89_DBG_TSSI, "[TSSI] %s: phy=%d\n",
> > +		    __func__, phy);
> > +
> > +	if (!rtwdev->is_tssi_mode[RF_PATH_A])
> > +		return;
> > +	if (!rtwdev->is_tssi_mode[RF_PATH_B])
> > +		return;
> > +
> > +	_tssi_disable(rtwdev, phy);
> > +
> > +	for (i = RF_PATH_A; i < RF_PATH_NUM_8852A; i++) {
> > +		_tssi_rf_setting(rtwdev, phy, i);
> > +		_tssi_set_sys(rtwdev, phy);
> > +		_tssi_set_tmeter_tbl(rtwdev, phy, i);
> > +		_tssi_pak(rtwdev, phy, i);
> > +	}
> > +
> > +	_tssi_enable(rtwdev, phy);
> > +	_tssi_set_efuse_to_de(rtwdev, phy);
> > +}
> > +
> > +void rtw8852a_tssi_track(struct rtw89_dev *rtwdev)
> > +{
> > +	_tssi_track(rtwdev);
> > +}
> 
> rtw8852a_tssi_track() is not used
> 

I'll check TSSI owner.
Will remove it if we don't need it, or call it if necessary.