On Fri, Jul 2, 2021 at 12:23 AM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: > On Fri, Jun 18, 2021 at 02:46:05PM +0800, Ping-Ke Shih wrote: > > +#ifdef CONFIG_RTW89_DEBUGMSG > > +unsigned int rtw89_debug_mask; > > +EXPORT_SYMBOL(rtw89_debug_mask); > > +module_param_named(debug_mask, rtw89_debug_mask, uint, 0644); > > +MODULE_PARM_DESC(debug_mask, "Debugging mask"); > > +#endif > > > For dynamic debugging we usually use ethtool msglvl. > Please, convert all dev_err/warn/inf.... to netif_ counterparts Have you ever looked at a WiFi driver? I haven't seen a single one that uses netif_*() for logging. On the other hand, almost every single one has a similar module parameter or debugfs knob for enabling different types of debug messages. As it stands, the NETIF_* categories don't really align at all with the kinds of message categories most WiFi drivers support. Do you propose adding a bunch of new options to the netif debug feature? Brian
