On Thu, 2021-07-01 at 23:54 +0300, Davis Mosenkovs wrote: > > > > > It seems that the 4.4 backport is broken. The problem is the fact that > > > > skb_mac_header is called before eth_type_trans(). This means that the > > > > mac header offset still has the default value of (u16)-1, resulting in > > > > the 64 KB memory offset that you observed. Agree. > > > > I think that for 4.4, the code should be changed to use skb->data > > > > instead of skb_mac_header. 4.9 looks broken in the same way. > > > > 5.4 seems fine, so newer kernels should be fine as well. Also agree. > > > Thanks for looking into this, can you submit a patch to fix this up in > > > the older kernel trees? > > Sorry, I don't have time to prepare and test the patches at the moment. > > > If testing procedure mentioned in my first email is sufficient (and > using skb->data is the correct solution in kernel trees where current > code doesn't work properly), I can make and test the patches. > Should I do that? Yes, please do. Thanks, johannes
