<Ajay.Kathat@xxxxxxxxxxxxx> writes: > From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> > > Instead of using static variable(isinit) move to priv struct. > Added hif_is_init function to set is_init variable. This is a good patch. But I also see one more static non-const variable: wlan.c: static u32 chipid; Upstream drivers should not use static variables, unless they are const. Please fix that also, but in a separate patch of course. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
