On Wed, 23 Jun 2021 21:23:27 +0200 Christian Lamparter <chunkeey@xxxxxxxxx> wrote: > On 23/06/2021 21:14, Pavel Skripkin wrote: > > In case of not supported chip the code jump > > to the error handling path, but _ret_ will be set to 0. > > Returning 0 from probe means, that ->probe() succeeded, but > > it's not true when chip is not supported. > > > > Fixes: f8914a14623a ("ath10k: restore QCA9880-AR1A (v1) detection") > > Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx> > > I think this is already fixed by: > > commit e2783e2f39ba99178dedfc1646d5cc0979d1bab3 > Author: Yang Yingliang <yangyingliang@xxxxxxxxxx> > Date: Mon May 31 17:41:28 2021 +0300 > > ath10k: add missing error return code in ath10k_pci_probe() > > Ah, i didn't check linux-next tree, my bad :( Thanks for pointing it out With regards, Pavel Skripkin