> -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Wednesday, June 23, 2021 9:00 PM > To: Pkshih > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] mac80211: Fix sw connection monitor and sw scan when STA is connected HE > > On Wed, 2021-06-23 at 12:49 +0000, Pkshih wrote: > > > -----Original Message----- > > > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > > > Sent: Wednesday, June 23, 2021 6:33 PM > > > To: Pkshih > > > Cc: linux-wireless@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH] mac80211: Fix sw connection monitor and sw scan > > > when STA is connected HE > > > > > > > Hi mac80211 team, > > > > > > > > We are working on Realtek 11ax driver, rtw89, not being merged > > > > yet. > > > > This driver uses software connection monitor and software scan, > > > > like > > > > our 11ac driver rtw88, > > > > but we found these two functions don't work properly due to > > > > mac80211 > > > > doesn't send > > > > null data frame when STA is connected HE. > > > > > > > > We search for the reason why it can't send null frame, but we > > > > don't > > > > get the answer. > > > > Possibly, it is because existing HE hardware supports hardware > > > > connection monitor > > > > and scan, or supports TWT to avoid sending null data frame to tell > > > > AP > > > > its PS mode. > > > > Could anyone enlighten me the reason? > > > > > > It was just a workaround for an iwlwifi specific issue that got left > > > in. > > > I just merged a patch from Felix to resolve that. > > > > > > > I check Felix's patch: > > https://patchwork.kernel.org/project/linux-wireless/patch/20210619101517.90806-1-nbd@xxxxxxxx/ > > > > > > I think we should revert the commit f39b07fdfb68 ("mac80211: HE STA > > disassoc due to QOS NULL not sent"), > > which fixes connection monitor due to QOS NULL not send. > > > > I agree, that makes sense. > > > > > Another place is ieee80211_send_null_response(); I'm not sure if we > > can remove > > the checking as well. > > Yes, I think so. > > Want to send patch(es) for that? > Sure. Two patches are sent: https://lore.kernel.org/linux-wireless/20210623134826.10318-1-pkshih@xxxxxxxxxxx/T/#t https://lore.kernel.org/linux-wireless/20210623134826.10318-2-pkshih@xxxxxxxxxxx/T/#u -- Ping-Ke
