On Tue, Jun 22, 2021 at 4:32 PM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> writes: > > > iwlmei is a driver that handles the communication with the > > Wireless driver of the CSME firmware. > > More details in the documentation included in this patch. > > A complicated new feature and just two sentences in the commit log? The > commit log should give a proper overview what the patch does and why. > This commit log really says to the reader "I don't care, find out > yourself". > > And being nice I did try to read few paragraphs from the patch but as I > didn't even see any explanation for CSME or SAP I gave up. > CSME stands for converged security and management engine. It is well known and has a driver in the kernel under drivers/misc/mei CSME is a CPU inside the chipset that runs a firmware that is also able to control the WLAN device. iwlwifi needs to negotiate with the firmware that runs on the CSME to take the device. The language they talk is SAP which is just a command based protocol. I can add that to the commit message. > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
