Search Linux Wireless

Re: [PATCH] mt76: mt7921: allow chip reset during device restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes:
> 
> > Disable chip full reset just during device probing but allow
> > it during hw restart.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> 
> [...]
> 
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> > @@ -160,7 +160,8 @@ struct mt7921_dev {
> >  	u16 chainmask;
> >  
> >  	struct work_struct reset_work;
> > -	bool hw_full_reset;
> > +	bool hw_full_reset:1;
> > +	bool hw_init_done:1;
> 
> Is there a specific reason why you use bitfields in a boolean? Looks
> strange to me.

Hi Kalle,

nope, there is no specific reason, I have just reused the same approach used in
mt76_queue_entry for skip_buf{0,1}.

Regards,
Lorenzo

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux