On Wed, 2008-09-24 at 17:19 +0200, Helmut Schaa wrote: > Am Mittwoch, 24. September 2008 16:46:18 schrieb Johannes Berg: > > On Wed, 2008-09-24 at 16:36 +0200, Helmut Schaa wrote: > > > Could somebody please have a look at the TODO comments (I have no idea > > > how to wait until all null-func frames are ACKed)? Thanks. > > > > It's not really possible. > > :( What I meant to say is that it'll give problems with drivers that don't do status reporting properly, and what are you going to do when one of them fails anyway? retry it? how long? assume the connection was lost if it isn't acked? I see little point in it to start with. > > > + netif_tx_wake_all_queues(sdata->dev); > > > > This is worsening a problem we already have -- you can enable queues > > that the driver asked to be disabled. Until we fix that, I don't think > > we should tempt our luck even more. > > I see! That's really problematic. > Do you have already an idea on how to fix it? Not really; introduce bits somewhere to keep track of who wants to enable/disable queues I guess. > > And why is sw_scanning false if bg_scanning is true anyway? > > During a background scan the sw_scanning flag is set when a scan phase is > active and unset when an operation phase is active. Therefore I did not need > to adapt all checks for sw_scanning. Oh, hmm, ok, that might make the enum problematic. Or do something like SCAN_OFF, SCAN_BG, SCAN_SW, SCAN_HW then you can check for scan >= SCAN_SW johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
