On Wed, 2008-09-24 at 10:44 +0200, Johannes Berg wrote: > On Wed, 2008-09-24 at 13:57 +0800, Zhu Yi wrote: > > From: Abhijeet Kolekar <abhijeet.kolekar@xxxxxxxxx> > > > > The patch adds channels sysfs entry for iwl3945. Make it consistent > > with iwlagn. > > I advocate just make it consistent by removing it entirely. > > > --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c > > +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c > > @@ -7666,8 +7666,60 @@ static DEVICE_ATTR(power_level, S_IWUSR | S_IRUSR, show_power_level, > > static ssize_t show_channels(struct device *d, > > struct device_attribute *attr, char *buf) > > { > > - /* all this shit doesn't belong into sysfs anyway */ Yeah, it seems odd. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html