Search Linux Wireless

Re: [PATCH] cfg80211: expose the rfkill device to the low level driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Emmanuel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on mac80211/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/cfg80211-expose-the-rfkill-device-to-the-low-level-driver/20210616-211511
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8b25a459eed15aebc25c2ce0a5bf20fea8eab638
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Emmanuel-Grumbach/cfg80211-expose-the-rfkill-device-to-the-low-level-driver/20210616-211511
        git checkout 8b25a459eed15aebc25c2ce0a5bf20fea8eab638
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from net/wireless/core.c:26:
   include/net/cfg80211.h: In function 'wiphy_rfkill_stop_polling':
   include/net/cfg80211.h:6669:2: error: implicit declaration of function 'rfkill_pause_polling' [-Werror=implicit-function-declaration]
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/core.h:14,
                    from net/wireless/nl80211.h:9,
                    from net/wireless/core.c:27:
   include/linux/rfkill.h: At top level:
>> include/linux/rfkill.h:110:6: warning: conflicting types for 'rfkill_pause_polling'
     110 | void rfkill_pause_polling(struct rfkill *rfkill);
         |      ^~~~~~~~~~~~~~~~~~~~
   In file included from net/wireless/core.c:26:
   include/net/cfg80211.h:6669:2: note: previous implicit declaration of 'rfkill_pause_polling' was here
    6669 |  rfkill_pause_polling(wiphy->rfkill);
         |  ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/rfkill_pause_polling +110 include/linux/rfkill.h

135900c182c321 Michael Buesch 2007-09-27  101  
19d337dff95cbf Johannes Berg  2009-06-02  102  /**
19d337dff95cbf Johannes Berg  2009-06-02  103   * rfkill_pause_polling(struct rfkill *rfkill)
19d337dff95cbf Johannes Berg  2009-06-02  104   *
19d337dff95cbf Johannes Berg  2009-06-02  105   * Pause polling -- say transmitter is off for other reasons.
19d337dff95cbf Johannes Berg  2009-06-02  106   * NOTE: not necessary for suspend/resume -- in that case the
dd21dfc645d5dc Johannes Berg  2016-01-20  107   * core stops polling anyway (but will also correctly handle
dd21dfc645d5dc Johannes Berg  2016-01-20  108   * the case of polling having been paused before suspend.)
19d337dff95cbf Johannes Berg  2009-06-02  109   */
19d337dff95cbf Johannes Berg  2009-06-02 @110  void rfkill_pause_polling(struct rfkill *rfkill);
cf4328cd949c20 Ivo van Doorn  2007-05-07  111  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux