On Tue, Jun 15, 2021 at 6:31 AM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Yiyuan GUO <yguoaz@xxxxxxxxx> wrote: > > > In function mwifiex_set_ibss_params, the variable index may remain > > zero if it is never altered inside the loop, leading to a potential > > divide by zero problem. > > > > Signed-off-by: Yiyuan GUO <yguoaz@xxxxxxxxxx> > > Brian explains in the report why the code is ok: > https://bugzilla.kernel.org/show_bug.cgi?id=212993#c1 Ah, forgot there was a patch for this too. FWIW, it's probably ok to submit such a patch, if just for safety's sake (future refactoring?). I just didn't figure it deserved an open "bug" entry, when it's clearly not one. > Patch set to Rejected. That's fine with me. Thanks, Brian