Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: > Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > >> wcn36xx_smd_set_power_params() can return an error. For the purposes of >> entering into suspend we need the suspend() function to trap and report >> errors up the stack. >> >> First step in this process is reporting the existing result code for >> wcn36xx_smd_set_power_params(). >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> Tested-by: Benjamin Li <benl@xxxxxxxxxxxx> >> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > > 12 patches applied to ath-next branch of ath.git, thanks. > > ba4e967379f0 wcn36xx: Return result of set_power_params in suspend > f2f49601067b wcn36xx: Run suspend for the first ieee80211_vif > 5478c41fce5d wcn36xx: Add ipv4 ARP offload support in suspend > 6feb634f4d9f wcn36xx: Do not flush indication queue on suspend/resume > c7a61af55976 wcn36xx: Add ipv6 address tracking > 1456223c4684 wcn36xx: Add ipv6 namespace offload in suspend > 8974e5917b31 wcn36xx: Add set_rekey_data callback > 6693f7675c9b wcn36xx: Add GTK offload to WoWLAN path > bedf1169bcae wcn36xx: Add GTK offload info to WoWLAN resume > 60f0078b1ebd wcn36xx: Add Host suspend indication support > ebe7c1a6635f wcn36xx: Add host resume request support > 1e2e8ee95734 wcn36xx: Enable WOWLAN flags BTW, I'm not sure about CONFIG_IPV6 checks but they looked minor so I applied these anyway. But can you check them anyway and send a followup patch if my hunch is correct? main.c:#if IS_ENABLED(CONFIG_IPV6) main.c:#if IS_ENABLED(CONFIG_IPV6) These two look ok. smd.c:#if IS_ENABLED(CONFIG_IPV6) wcn36xx.h:#if IS_ENABLED(CONFIG_IPV6) But these two seem unnecessary, at least I was not able to find anything which would require these. Although I didn't have time to do a build test so of course I might have missed something. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches