On Mon, Sep 22, 2008 at 6:18 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2008-09-22 at 18:12 +0300, Tomas Winkler wrote: >> On Mon, Sep 22, 2008 at 5:59 PM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Mon, 2008-09-22 at 17:10 +0300, Tomas Winkler wrote: >> >> From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> >> >> >> >> This patch fixes the led behavior in IBSS. After we joined an IBSS cell we >> >> need to inform the led that we got associated. Although there is no 802.11 >> >> association in IBSS mode, the semantic of "There is a link" is relevant. >> >> This allows the led to blink in IBSS mode (at least this solves a bug for >> >> iwlwifi). >> > >> > Doesn't it also have to be turned off again at some point? Or is that >> > done? Other than that looks fine to me. >> >> I've asked my self the same question the answer is not clear. We >> switch the led off on close/ifdown by radio led trigger. >> Note in IBSS is always connected, carrier is always on if I'm not mistaken. > > I think you can configure it off though, by setting the "essid" (oh how > I hate that) to "off" or something? Let see if we hit real world scenario, this patch fixes bug opened for long time. Not sure, and we can always fix it > when we see the problem, I don't really care much about the LEDs, I > don't have any. Can send you few, just pick a color :) Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html