Re: [RFC PATCH 2/4] mac80211: minstrel_ht: fix minstrel_aggr_check for encap offload

[Ryder Lee <ryder.lee@xxxxxxxxxxxx>]

On Tue, 2021-05-25 at 15:00 +0200, Johannes Berg wrote:
> On Thu, 2021-05-20 at 03:56 +0800, Ryder Lee wrote:
> > 
> > +	if (!(info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) &&
> > +	    unlikely(!ieee80211_is_data_qos(hdr->frame_control)))
> >  		return;
> 
> That unlikely() placement seems odd?
> 
> johannes
> 



I thought about
	if (unlikely(!(info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) &&
	    !ieee80211_is_data_qos(hdr->frame_control)))

...until I found a similiar case in ieee80211_get_txq, so I kept it in
that way.

Ryder