"tiantao (H)" <tiantao6@xxxxxxxxxx> writes: > 在 2021/5/21 0:51, Michael Büsch 写道: >> On Tue, 18 May 2021 10:52:32 +0800 >> Tian Tao <tiantao6@xxxxxxxxxxxxx> wrote: >> >>> The return value of ssb_bus_unregister can only be 0 or 1, so this >>> condition if (err == -EBUSY) will not hold, so delete it. >>> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus) >>> int err; >>> err = ssb_gpio_unregister(bus); >>> - if (err == -EBUSY) >>> - pr_debug("Some GPIOs are still in use\n"); >>> - else if (err) >>> + if (err) >>> pr_debug("Can not unregister GPIO driver: %i\n", err); >>> ssb_buses_lock(); >> Good catch. >> Minor correction: The return value can be 0 or -1. > > yes, you are right. thanks again.:-) I'll fix the commit log to match that. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches