On 2021/5/11 9:11, Leizhen (ThunderTown) wrote:
>
>
> On 2021/5/11 4:02, Andrew Lunn wrote:
>> On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
>>> These TODO empty code are added by
>>> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
>>> been more than a decade now. I don't think anyone who wants to perfect
>>> this workaround can follow this TODO tip exactly. Instead, it limits them
>>> to new thinking. Remove it will be better.
>>>
>>> No functional change.
>>
>> No function change, apart from the new warning?
>>
>> Does your bot to compile the change and look for new warnings/errors?
>
> Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it.
I got it. It reported by W=1.
>
>>
>> Andrew
>>
>> .
>>
