On Thu, 2021-05-06 at 10:44 +0000, Kumar, M Chetan wrote: > Hi Loic, > > > > > > > Implements a char device for MBIM protocol communication & > > > provides a > > > simple IOCTL for max transfer buffer size configuration. > > > > > > Signed-off-by: M Chetan Kumar <m.chetan.kumar@xxxxxxxxx> > > > > Now that the initial wwan framework support landed, could you > > migrate to it > > for creating the MBIM 'WWAN port' instead of creating yet another > > char > > driver? I see you introduced an IOCTL for packet size, I see no > > objection to > > add that in the wwan core. > > > > Sure, we have started the migration to MBIM 'WWAN port'. The next > version of patch > would contain these adaptations. > > If wwan core supports IOCTL for packet size, then we shall remove > that piece of > implementation in driver code. There has got to be a better way to do that than an ioctl. ioctls are not looked on favorably these days. Usually it's sysfs files or netlink config instead. Dan
