On Thu, Apr 22, 2021 at 10:04:29PM +0200, Johannes Berg wrote: > On Thu, 2021-04-22 at 15:00 -0500, Gustavo A. R. Silva wrote: > > > > Changes in v2: > > - Use direct struct assignments instead of memcpy(). > > - Fix one more instance of this same issue in function > > iw_handler_get_thrspy(). > > - Update changelog text. > > Thanks. > > > - Add Kees' RB tag. > > He probably won't mind in this case, but you did some pretty substantial > changes to the patch, so I really wouldn't recommend keeping it there. Thanks for double-checking! Yeah, I'm fine with it; Gustavo and I had talked in the past about similar solutions in other places, so he forwarded the intent from those conversations. (Not that you had any visibility into that!) But, yes, still: Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> Thanks! -- Kees Cook