> -----Original Message----- > From: Pkshih [mailto:pkshih@xxxxxxxxxxx] > Sent: Monday, April 12, 2021 4:11 PM > To: Kalle Valo > Cc: tony0620emma@xxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; DeanKu; Bernie Huang; Shaofu; Steven Ting; > Kevin Yang > Subject: RE: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame > > > > -----Original Message----- > > From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx [mailto:kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx] On > > Behalf Of Kalle Valo > > Sent: Sunday, April 11, 2021 5:21 PM > > To: Pkshih > > Cc: tony0620emma@xxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; DeanKu; Bernie Huang; Shaofu; Steven > Ting; > > Kevin Yang > > Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame > > > > Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > > > > > From: Shao-Fu Cheng <shaofu@xxxxxxxxxxx> > > > > > > By default the driver uses the 1M and 6M rate for managemnt frames > > > in 2G and 5G bands respectively. But when the basic rates is configured > > > from the mac80211, we need to send the management frames according the > > > basic rates. > > > > > > This commit makes the driver use the lowest basic rates to send > > > the management frames and a debufs entry to enable/disable force to use > > > the lowest rate 1M/6M for 2.4G/5G bands. > > > > > > obtain current setting > > > cat /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates > > > > > > force lowest rate: > > > echo 1 > /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates > > > > > > Signed-off-by: Shao-Fu Cheng <shaofu@xxxxxxxxxxx> > > > Signed-off-by: Yu-Yen Ting <steventing@xxxxxxxxxxx> > > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > > > Why is a debugfs interface needed? > > > > By default, driver follows AP's basic rates that may be 24M and above, and > does association with 24M rate. If AP is far away, it may be hard to communicate > with 24M rate. Therefore, we add a debugfs to allow driver to send management > frames with low rate 6M or 1M. > If an AP is configured basic rate 24M or above, I think the IT wants STA follows the rates. If we have an interface for normal users, it will break the IT's desire. So, we use a debugfs to help remote debug only, in case user reports he can't connect to an AP with low RSSI. I think it's worth that driver can follow AP's basic rate, so I make it as an individual patch; debugfs as second one. If you need to think if debugfs is necessary, I hope we can land the first patch first. The patchset is sent https://lore.kernel.org/linux-wireless/20210422030413.9738-1-pkshih@xxxxxxxxxxx/T/#t -- Ping-Ke
