On Thursday 18 September 2008, Henrique de Moraes Holschuh wrote: > On Thu, 18 Sep 2008, Ivo van Doorn wrote: > > On Thursday 18 September 2008, Henrique de Moraes Holschuh wrote: > > > On Thu, 18 Sep 2008, Ivo van Doorn wrote: > > > > On Thursday 18 September 2008, Johannes Berg wrote: > > > > > On Thu, 2008-09-18 at 19:52 +0200, Ivo van Doorn wrote: > > > > > > From rfkill.h: > > > > > > RFKILL_STATE_SOFT_BLOCKED = 0, /* Radio output blocked */ > > > > > > RFKILL_STATE_UNBLOCKED = 1, /* Radio output allowed */ > > > > > > RFKILL_STATE_HARD_BLOCKED = 2, /* Output blocked, non-overrideable */ > > > > > > > > > > > > Since b43 has a rfkill mechanism that does switch of the radio when RFKILL is set to BLOCK > > > > > > after a key press, it should send RFKILL_STATE_HARD_BLOCKED because rfkill cannot override > > > > > > it. > > > > > > > > > > > > rt2x00 hardware does not change the radio state when RFKILL is set to BLOCK after a key press, > > > > > > the state is therefor overridable and it can send RFKILL_STATE_SOFT_BLOCKED to rfkill. > > > > > > > > > > If rt2x00 has no meaning of "hardware blocked", why is the button not a > > > > > simple input device? > > > > > > > > Because I had that discussion with Henrique and that ended with a "it isn't a input device"... > > > > > > Because I NEVER UNDERSTOOD it was not a hardware rfkill line until a few > > > posts ago in this thread. Argh. My deepest apologies for that screw up. > > > > > > Now that I do, my answer is "depends on how the platform used that input pin". > > > > > > If it is directly connected to a switch (you get on/off from it) or a button > > > (you get "I have been pressed, please toggle the state"), it is an input > > > device. [a] > > > > > > If it is directly connected to some crap inside the platform, that is > > > controlled by firmware, it is NOT an input device. [b] > > > > Ok, rt2x00 is definately [a] > > > > > I hope it is a switch, and that you can just always provide an input device > > > that issues some sort of EV_SW event (if you need it, we ask Dmitry to add > > > EV_SW SW_WLAN). > > > > Ok, I'll readd the input_polldev to rt2x00 again then. :) > > But do use EV_SW if it is a switch, please :-) Sure. > Even if that means a need to > get EV_SW SW_WLAN out of Dmitry... I don't know if rt2x000 wants SW_WLAN or > SW_RFKILL_ALL. Not sure either, there is no way to determine which of the 2 should be used. Oh an to make sure I get it completely right this time: When I implement the input polldev, I no longer have to use rfkill_force_state() right? Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
