On Thu, 2021-04-15 at 14:21 +0200, Johannes Berg wrote:
> On Thu, 2021-04-15 at 14:04 +0200, Hans de Goede wrote:
> > This fixes the same locking problem fixed by commit 2800aadc18a6 ("iwlwifi:
> > Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()") but then for
> > the gen2 variant of enqueue_hcmd().
> >
> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
> > disabled (e.g. from LED core). We can't enable BHs in such a situation.
> >
> > Turn the unconditional BH-enable/BH-disable code into
> > hardirq-disable/conditional-enable.
> >
> > This fixes the warning below.
>
> I believe Jiri posted the same patch:
>
> https://lore.kernel.org/linux-wireless/nycvar.YFH.7.76.2104070918090.12405@xxxxxxxxxxxxx/
>
> Not sure where it is now though, I guess Luca can comment.
Jiri's patch is in 5.12-rc7.
> I also had another fix in this area too.
Your patch was not sent out yet. Is this serious enough to justify
trying to get it into 5.12 so late in the series? Maybe it makes more
sense to wait for stable...
--
Luca.
