On 13-04-2021 09:45, Shawn Guo wrote:
On Mon, Apr 12, 2021 at 10:09:38AM +0200, Arend van Spriel wrote:
On 08-04-2021 13:30, Shawn Guo wrote:
With any regulatory domain requests coming from either user space or
802.11 IE (Information Element), the country is coded in ISO3166
standard. It needs to be translated to firmware country code and
revision with the mapping info in settings->country_codes table.
Support populate country_codes table by parsing the mapping from DT.
comment below, but you may add...
Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Thanks for reviewing, Arend.
Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
---
.../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index a7554265f95f..ea5c7f434c2c 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
[...]
@@ -47,6 +96,10 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
!of_device_is_compatible(np, "brcm,bcm4329-fmac"))
return;
+ ret = brcmf_of_get_country_codes(dev, settings);
+ if (ret)
+ dev_warn(dev, "failed to get OF country code map\n");
First of all I prefer to use brcmf_err and add ret value to the print
message " (err=%d)\n".
Okay.
Another thing is that this mapping is not only
applicable for SDIO devices so you may consider doing this for other bus
types as well which requires a bit more rework here.
Right. I will take care of it, if we can convince Kalle that having
this data in DT is not such a bad idea.
Sure. So let me explain a bit how our internal regulatory data is
organized. The country revision is needed because the rf parameters that
provide regulatory compliance are tweaked per platform/customer so
depending on the rf path tight to the chip we need to use a certain
country revision. As such they could be seen as device specific
calibration data which is something that is already supported in the
devicetree bindings.
Regards,
Arend
