Pkshih <pkshih@xxxxxxxxxxx> writes: >> -----Original Message----- >> From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx >> [mailto:kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx] On >> Behalf Of Kalle Valo >> Sent: Sunday, April 11, 2021 5:21 PM >> To: Pkshih >> Cc: tony0620emma@xxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; DeanKu; >> Bernie Huang; Shaofu; Steven Ting; >> Kevin Yang >> Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame >> >> Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: >> >> > From: Shao-Fu Cheng <shaofu@xxxxxxxxxxx> >> > >> > By default the driver uses the 1M and 6M rate for managemnt frames >> > in 2G and 5G bands respectively. But when the basic rates is configured >> > from the mac80211, we need to send the management frames according the >> > basic rates. >> > >> > This commit makes the driver use the lowest basic rates to send >> > the management frames and a debufs entry to enable/disable force to use >> > the lowest rate 1M/6M for 2.4G/5G bands. >> > >> > obtain current setting >> > cat /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates >> > >> > force lowest rate: >> > echo 1 > /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates >> > >> > Signed-off-by: Shao-Fu Cheng <shaofu@xxxxxxxxxxx> >> > Signed-off-by: Yu-Yen Ting <steventing@xxxxxxxxxxx> >> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> >> Why is a debugfs interface needed? >> > > By default, driver follows AP's basic rates that may be 24M and above, and > does association with 24M rate. If AP is far away, it may be hard to communicate > with 24M rate. Therefore, we add a debugfs to allow driver to send management > frames with low rate 6M or 1M. debugfs is for R&D level testing and debugging, not normal user configuration. To me it looks like something like that should be in nl80211. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
