On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote:
> From: John Crispin <john@xxxxxxxxxxx>
>
> Add a new helper ieee80211_set_multiple_bssid_options() takes propagating
> the cfg80211 data down the stack.
>
> The patch also makes sure that all members of the bss set will get closed
> when either of them is shutdown.
s/either/any/
>
> static int ieee80211_del_iface(struct wiphy *wiphy, struct wireless_dev *wdev)
> {
> + struct ieee80211_sub_if_data *sdata;
> +
> + sdata = IEEE80211_WDEV_TO_SUB_IF(wdev);
can be one line
> + if (sdata && sdata->vif.type == NL80211_IFTYPE_AP) {
> + if (sdata->vif.multiple_bssid.flags & IEEE80211_VIF_MBSS_TRANSMITTING) {
> + struct ieee80211_sub_if_data *child;
> +
> + rcu_read_lock();
> + list_for_each_entry_rcu(child, &sdata->local->interfaces, list)
> + if (child->vif.multiple_bssid.parent == &sdata->vif)
> + dev_close(child->wdev.netdev);
> + rcu_read_unlock();
You never tested this properly, this is wrong.
johannes
