On 2021-03-26 22:09, Johannes Berg wrote: >> >> + skb->data[skb->len] = 0; >> wiphy_info(mt76_hw(dev)->wiphy, "%s: %s", type, data); >> } >> > > Are you sure there's always enough space to write to the skb? Following > the code up I'm not even sure it's always a linear skb :-) > > Might be safer/better to do > > wiphy_info(..., "%s: %*s", type, skb->len - sizeof(*rxd), > data); > > instead? Maybe it does trust the firmware too much. I'll send a v2 based on your suggestion. Thanks, - Felix
