On Sat, 13 Mar 2021, Luca Coelho wrote: > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a situation. > > > > > > > > > > > > > > > > Turn the unconditional BH-enable/BH-disable code into > > > > > > > > hardirq-disable/conditional-enable. > > > > > > > > > > > > > > > > This fixes the warning below. > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > friendly ping on this one ... > > > > > > > > > > > > Luca, > > > > > > > > > > > > Johannes is telling me that he merged this patch internally, but I have no > > > > > > idea what is happening to it ... ? > > > > > > > > > > > > The reported splat is a clear bug, so it should be fixed one way or the > > > > > > other. > > > > > > > > > > Should I take this to wireless-drivers? > > > > > > > > I can't speak for the maintainers, but as far as I am concerned, it > > > > definitely is a 5.12 material, as it fixes real scheduling bug. > > > > > > Yes, please take this to w-d. We have a similar patch internally, but > > > there's a backlog and it will take me some time to get to it. I'll > > > resolve eventual conflicts when time comes. > > > > Ok, can I have your ack for patchwork? > > Sorry, forgot that. > > Acked-by: Luca Coelho <luciano.coelho@xxxxxxxxx> Sorry for sounding like broken record :) but this fix is still not in any tree as far as I can tell. And it's fixing real scheduling in atomic bug. Thanks, -- Jiri Kosina SUSE Labs
