Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Sat, 2021-03-20 at 01:13 +0100, Toke Høiland-Jørgensen wrote: >> >> One consequence of this is that we create a strict priority queue for >> management frames. > > Yes, for iwlwifi that's actually a change. For everyone else (not > setting BUFF_MMPDU_TXQ or STA_MMPDU_TXQ) it already is since it goes > directly to ->tx() and from there to the hardware queue(s). Ah, right, of course; so not much change at all. Cool. >> With all the possibilities for badness (such as the >> ability of starving all other queues) that carries with it. I guess >> that's probably fine for management frames, though, right? As in, there >> is some other mechanism that prevents abuse of this? > > Well, there's just not that many management frames to start with? And > only wpa_supplicant (or root in general) can create them. So I don't > think we need to worry about that yet. With QoS-mgmt frames we might > eventually want to think about that, but even there I'd say we never > really want to drop them. Yup, that's what I meant with "some other mechanism to prevent abuse". Great. Feel free to add my: Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
