Hi, On Mon, 2021-03-22 at 10:43 +0100, Maxime Bizon wrote: > > Short-circuit the processing of management frames. To keep the > > impact minimal, only put them on the frags queue and check the > > tid == management only for doing that and to skip the airtime > > fairness checks, if applicable. > > After your patch, what are the actual effects of HW_STA_MMPDU_TXQ and > HW_BUFF_MMPDU_TXQ ? Well, my patch doesn't change the effect of those significantly. The idea for iwlwifi was that it doesn't actually like ->tx() to get called, but much prefers a TXQ where the frame is, and then it can pull it whenever it can transmit it. This was the key requirement here, and it doesn't change: instead of tx() getting called with the frames, the frames go to the TXQ instead and wake_tx_queue() is called, and then the driver later pulls the frames and pushes them to the hardware. What does change is that management frames are no longer subject to codel and inter-flow issues, and also note that the hash of a management frame isn't actually well-defined. johannes
