Re: [PATCH] wilc1000: fix a loop timeout condition

[<Ajay.Kathat@xxxxxxxxxxxxx>]

On 19/03/21 8:17 pm, Dan Carpenter wrote:
> 
> If the loop fails, the "while(trials--) {" loop will exit with "trials"
> set to -1.  The test for that expects it to end with "trials" set to 0
> so the warning message will not be printed.
> 
> Fix this by changing from a post-op to a pre-op.  This does mean that
> we only make 99 attempts instead of 100 but that's okay.
> 
> Fixes: f135a1571a05 ("wilc1000: Support chip sleep over SPI")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks Dan.

Acked-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>

> ---
>  drivers/net/wireless/microchip/wilc1000/wlan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
> index d4a90c490084..2030fc7f53ca 100644
> --- a/drivers/net/wireless/microchip/wilc1000/wlan.c
> +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
> @@ -575,7 +575,7 @@ void chip_allow_sleep(struct wilc *wilc)
>                 to_host_from_fw_bit = WILC_SPI_FW_TO_HOST_BIT;
>         }
> 
> -       while (trials--) {
> +       while (--trials) {
>                 ret = hif_func->hif_read_reg(wilc, to_host_from_fw_reg, &reg);
>                 if (ret)
>                         return;
> --
> 2.30.2
>