On Thu, Mar 18, 2021 at 12:55 AM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > Hi Peter, > > > > I'm seeing warnings like this on 5.12.0-rc2 which I think were caused > > by your patch. > > > > [ 4.898946][ T455] ------------[ cut here ]------------ > > [ 4.899434][ T455] RTNL: assertion failed at net/core/dev.c (10988) > > Yes, sorry about that. I clearly didn't audit that particular code path > (well enough, or at all) with the locking changes. > > Even worse, it probably deadlocks? Yes, it was deadlocking after a few minutes, although at that time I hadn't confirmed that the deadlock was being caused by the patch or by some other issue. > In any case, I fixed it here, I believe: > > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=77cbf790e5b482256662e14c8b6ef4fecb07d06d I cherry-picked that patch and tested it on my setup, and it fixed both the warnings and the deadlocks. So if you like you can add my: Tested-by: Peter Collingbourne <pcc@xxxxxxxxxx> to that patch. Peter
